This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Replace in with scope const for Throwable.toString#2782
Closed
JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:tostring_in
Closed
Replace in with scope const for Throwable.toString#2782JinShil wants to merge 1 commit intodlang:masterfrom JinShil:tostring_in
in with scope const for Throwable.toString#2782JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:tostring_in
Conversation
thewilsonator
approved these changes
Sep 1, 2019
JinShil
commented
Sep 1, 2019
| { | ||
| string s; | ||
| toString((buf) { s ~= buf; }); | ||
| toString((scope const buf) { s ~= buf; }); |
Contributor
Author
There was a problem hiding this comment.
Shouldn't the compiler be able to infer the scope const here?
Contributor
Author
|
A decision about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to
#2676
dlang/phobos#7110
#2680
#2684
#2693
#2694
#2695
#2696
#2697
#2699
#2702
#2704
#2781
This one of several PRs I intend to submit, breaking up #2677 into multiple PRs.
Background
This PR is in support of dlang/dmd#10382
inas a parameter storage class is defined asscope const. Howeverinhas not yetbeen properly implemented so its current implementation is equivalent to
const. Properlyimplementing
innow will likely break code, so it is recommended to avoid usingin, andexplicitly use
constorscope constinstead, untilinis properly implemented.The use of
inas a parameter storage class is already discouraged in the documentation. See https://dlang.org/spec/function.html#parameters